Re: [Tails-dev] Fix for keyboard layouts in the greeter, ple…

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] Fix for keyboard layouts in the greeter, please review
winterfairy@??? wrote (21 Nov 2013 14:57:57 GMT) :
> intrigeri wrote:
>> winterfairy wrote:
>>>    I am a bit uncertain, as recently "hrv" has been added
>>>    for the keyboard layout "us/hbs" (serbo-croatian (us)).
>>>    I do not really know if "hr" (croatian) keyboard layout
>>>    is preferred for croatia.

>>>
>>>    Fedora installer selects "hr" it seems.

>>
>> It would be awesome to have these uncertainties cleared,


> There are a few Croatian translators on Tor projects Transifex page.
> I will go ahead and ask them, they would know the best.


Perfect.

>> If not,
>> I think I'd rather not fixed a problem that nobody is affected by...
>> and the day we receive a complain, then we'll learn at the same time
>> what is their preferred keyboard layout :)


> Agree.


> Should I rebase my branch without the Sardinian commit, or revert it?


In general, I prefer if you revert it. (I personally dislike having to
review a branch entirely again due to history rewriting. I might
squash the branch to make its history cleaner — without content change
— before merging, if I think of it at that time.)

> Or maybe rebase my branch with only the norwegian fix, so it definitely
> makes it for the next Tails release? I really wanted to fix the norwegian
> keyboard support for the next Tails release, the other languages were just
> a bonus as they belonged to the same bug report.


That would work too.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc