so yes, finally I found a way to publish the artifacts on a PR, see the
example here:
https://github.com/libremesh/lime-app/pull/398
Now a PR with the label `artifact` will run an action that publishes
the artifact (tar.gz).
To find the artifacts for the moment there are some ways:
- At the bottom of the workflow page.
https://github.com/libremesh/lime-app/actions/runs/7846987559
- On the job itself, for example
https://github.com/libremesh/lime-app/actions/runs/7846987559/job/21414928637#step:5:19
However, there are a way that using a GH bot, the artifact url can be
published as comment on the PR itself. But, to do this, i need to give
permissions to the GITHUB_TOKEN of the project...
On this commit i disabled this feature because i have not enough
permisions on libremesh to do the necessary things.
https://github.com/libremesh/lime-app/pull/398/commits/bcaa1211985681bce3423952edbfb8287fc6c887
After look for a while, i found what we should do to be able to show the
artifact url inside the pr:
https://dev.to/github/the-githubtoken-in-github-actions-how-it-works-change-permissions-customizations-3cgp
Who can give permissions for that? Could be helpful to publish every new
compiled version on the PR for testing
ps: for some reason the action that have to run with label is not
working and i dont know why. It worked before lol, maybe is a GH thing...
BTW the POC is there, just need some fixes
Selan Kon via LibreMesh:
> Thanks for the suggestion, I am considering the best way to do this,
> since we already have a build github action we provably only need to
> expose the built package.
>
> Lets check for a while
>
> Germán Ferrero via LibreMesh:
>> Maybe as an alternative way to test the pull requests, Selan could build
>> the the app, share with you build files as a build.tar.gz that you then
>> untar at /var/www/app (please check the path). Remember backup and rm
>> that
>> directory first.
>>
>> El vie., 9 de feb. de 2024 09:54, Hiure via LibreMesh
>> <libremesh@???>
>> escribió:
>>
>>> Hi Selan,
>>>
>>>
>>> Thanks!
>>>
>>> Thanks to you for maintaining the lime app.
>>>
>>>
>>> Which base version of OWRT are you going to test?
>>>
>>> I am using v23.05.2
>>>
>>>
>>> To test it you need to set up development environment. At this
>>> moment, we
>>> are using node version 16 (version 18 has an error to fix). If you don't
>>> have this version installed i suggest you to use NVM[0] to select the
>>> specific version (nvm use v16.20.0). I also suggest to use yarn
>>> instead of
>>> npm. I have to update the README.md
>>>
>>> Once you have
>>>
>>> git clone https://github.com/libremesh/lime-app.git limeapp
>>> cd limeapp
>>> nvm use v16.20.0
>>> yarn
>>>
>>> after this step return:
>>>
>>> ```
>>>
>>> ... thousands of warnings
>>>
>>> warning storybook > @storybook/cli > jscodeshift >
>>> @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been
>>> merged to the ECMAScript standard and thus this plugin is no longer
>>> maintained. Please use @babel/plugin-transform-optional-chaining
>>> instead.
>>> [2/4] Fetching packages...
>>> error commander@12.0.0: The engine "node" is incompatible with this
>>> module. Expected version ">=18". Got "16.20.0"
>>> error Found incompatible module.
>>>
>>> ```
>>>
>>>
>>> NODE_HOST=10.13.0.2 yarn dev
>>>
>>> This NODE_HOST variable should point to a router with an updated version
>>> of the lime packages (the needed changes are already merged on main
>>> branch,
>>> so if is updated will work).
>>>
>>> NODE_HOST variable will enable the limeapp acting as a proxy. So, you
>>> can
>>> point any router on the network (basically lime app "server" is
>>> running on
>>> your computer and making the requests to the specified point).
>>>
>>> After that, you have to access to your localhost:8080 and you should see
>>> the new landing page working without any bugs or erros :P 🤞
>>>
>>>
>>> out of curiosity i tried npm install and npm run dev and i got it to
>>> run.
>>>
>>> However, in the browser when accessing localhost:8080 I got the
>>> following
>>> error in the console:
>>> ```
>>> Uncaught TypeError: node.most_active.iface is undefined
>>> ```
>>> and
>>>
>>> ```
>>> {
>>> "code": -32002,
>>> "message": "Access denied"
>>> }
>>> ```
>>>
>>> Abraços
>>>
>>> Hiure
>>> --
>>> LibreMesh mailing list
>>> LibreMesh@???
>>> https://www.autistici.org/mailman/listinfo/libremesh
>>>
>>
>>
