Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab…

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab MRs
Hi,

Zen Fu (2021-04-07):
> Another thing that could be explicitely documented is whether a reviewer
> should/could merge code after a review or not. This may differ from team
> to team because not always the assignee has privileges to merge. Maybe
> we could explicitely say when we expect the reviewer to merge? Or maybe
> the MR should then be re-assigned to someone that can actually merge? I
> don't think we need to make this very complex, but as it's a question
> that has popped up for me I'm raising it here.


The intention of our current doc is to cover this case:
https://tails.boum.org/contribute/merge_policy/#merge

Is it unclear, buggy, or lacking?

Cheers!