On 31/10/14 16:02, intrigeri wrote:
> Hi,
>
> intrigeri wrote (31 Oct 2014 12:55:44 GMT) :
>>> + when "the I2P Browser"
>>> + user = "i2pbrowesr"
>
>> XXX
>
> Ooops, I forgot this one. Obviously the test fails, so I think I've
> fixed it in e44f97c.
>
> No big deal, but it makes me question how much trust I can put, as
> a reviewer, into "I've tested it (both manually and automatically)
> very thoroughly" => how much change did happen on this branch *after*
> you tested it thoroughly?
I have no good explanation for this. The test suite ran well for me but
I may have focused more on the Unsafe Browser. Any way, let's interpret
that quote lightly, and in any case the merger should test the stuff to
their satisfaction on their own, right? :)
Cheers!
