Kill Your TV wrote (21 Nov 2013 19:20:32 GMT) :
>> * regarding commit c32cab5 ("I2P: Document ferm exceptions"): the
>> HTML table seems a bit too much markup for me; how about just using
>> a simple list? (not a blocker either, just nitpicking probably ;)
>>
> Heh..OK. I can change it to a list if that'd be preferred.
Yes, please (but you can save it for a future iteration, let's get
the rest ready to merge first).
>> * config/chroot_local-hooks/16-i2p_config still reads:
>> # Remove the false.i2p outproxy from i2ptunnel
>> # We already go out through Tor so this will never be reached
>> anyway. sed -i '/^tunnel.0.proxyList/d' "$I2P/i2ptunnel.config"
>> Is this still relevant? At least the comment isn't anymore,
>> right?.
> This one should be 'OK'. That outproxy is for visiting "clearnet"
> sites and those go out through Tor because of the FoxyProxy rules.
> Without the FoxyProxy rules all http://* traffic would go out via I2P
> with traffic to non-I2P sites being routed to a squid proxy running at
> http://false.i2p.
> This change is more cosmetic than anything since that
> block could be removed and nothing would be functionally different for
> a Tails user. The goal of this stanza/section was to remove the
> false.i2p outproxy from the I2PTunnel configuration to try to prevent
> end-users that are familiar with I2P from being confused by seeing a
> configured outproxy in the interface.
OK, makes sense, thanks for clarifying. So, only the code comment
needs an update, cool.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
