On Thu, 21 Nov 2013 17:50:09 +0000 (UTC)
intrigeri <intrigeri@???> wrote:
> Hi,
>
> Kill Your TV wrote (21 Nov 2013 16:58:53 GMT) :
> > I just pushed what's likely the last of the changes for 0.22.
>
> Looks good to me, modulo a few comments:
>
> * regarding commit 95ca91a ("document the need for admin password"):
> wouldn't this be more appropriate for the end-user documentation?
> (not a blocker, just something that could be improved in the future)
>
Yeah that might be better. I can do the improvement in the future.
> * regarding commit c32cab5 ("I2P: Document ferm exceptions"): the
> HTML table seems a bit too much markup for me; how about just using
> a simple list? (not a blocker either, just nitpicking probably ;)
>
Heh..OK. I can change it to a list if that'd be preferred.
> * config/chroot_local-hooks/16-i2p_config still reads:
> # Remove the false.i2p outproxy from i2ptunnel
> # We already go out through Tor so this will never be reached
> anyway. sed -i '/^tunnel.0.proxyList/d' "$I2P/i2ptunnel.config"
> Is this still relevant? At least the comment isn't anymore,
> right?.
This one should be 'OK'. That outproxy is for visiting "clearnet"
sites and those go out through Tor because of the FoxyProxy rules.
Without the FoxyProxy rules all
http://* traffic would go out via I2P
with traffic to non-I2P sites being routed to a squid proxy running at
http://false.i2p.
This change is more cosmetic than anything since that
block could be removed and nothing would be functionally different for
a Tails user. The goal of this stanza/section was to remove the
false.i2p outproxy from the I2PTunnel configuration to try to prevent
end-users that are familiar with I2P from being confused by seeing a
configured outproxy in the interface.
