Re: [Tails-dev] first patch attempt

Delete this message

Reply to this message
Author: intrigeri
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] first patch attempt
Hi,

Sina S wrote (26 Sep 2013 13:55:46 GMT) :
> I only tested the logic of the line that I wrote in ipython, I didn't run a
> "real" test. If this isn't good enough I completely understand and will
> come back with confirmation ASAP after a real test.


Yes, please :)

> Is there any documentation on how to import my add my patched
> liveusb-creator into the ISO?


As a developer without write access to our APT repository, you would
have to build a .deb with your patch [1], drop it into
config/chroot_local-packages, and build an ISO.

[1] https://tails.boum.org/contribute/release_process/liveusb-creator/

This would be the preferred way to test your patch, and it's how we
expect core developers to do it. However, I would strongly advise you
do *not* do this yet: you're likely to spend far too much time on it,
and unless you've always wanted to learn a lot about pbuilder,
git-buildpackage, source/binary Debian packages and friends, I expect
you end up quite frustrated. Let's save this for later, and make your
initial contribution a bit more fun.

Instead, I suggest you just patch the Python file in-place, in
a running Tails system running from USB, then create a few .iso files
in /lib/live/boot/medium/, run clone'n'upgrade and check if the files
have landed on the target USB stick.

Then, you can come back to us with something you have tested, and I'm
happy to merge it... and then I can point you to another ticket, if
you wish :)

> Or should I just mount ISO as loopback and apply the patch there?


This is more complicated, and not really more useful, as patching the
Python files in a running Tails system, and trying from there.

> As far as the output goes, seems like a good idea to me,
> I was just trying to make it a "one liner" ;)


Let's optimize for maintainability rather than for screen or
storage space.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc