Re: [Tails-dev] Fix in tails-greeter

Delete this message

Reply to this message
Autore: Andres Gomez Ramirez
Data:  
To: The Tails public development discussion list
Oggetto: Re: [Tails-dev] Fix in tails-greeter
> It only works if you restart the gdm3 service from a text console
>(tty1, etc. => CTRL-ALT-F1). If you run `service gdm3 restart' from X,
>the stop action kills X, and then the Terminal, and then the start
>action is not run.


> Can you retry this way?


>IMHO the easiest to test such patches during initial development is
>often to add a patch to config/chroot_local-patches/ -- this nicely
>works around the requirement to learn git-buildpackage, pbuilder &
>friends :) Of course this only works for programs written in
>interpreted languages, which happens to be the case for all our custom
>programs shipped as .deb's.


ok thanks, great explanation! I've attached two new patches for greeter persistence and admin password mismatch.

CheersFrom 497237607b1600a065f532791f41849fa14fd311 Mon Sep 17 00:00:00 2001
From: kurono <andres.gomez@???>
Date: Sun, 8 Sep 2013 23:19:51 +0200
Subject: [PATCH] Display a warning icon on greeter admin password mismatch

---
 glade/optionswindow.glade |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/glade/optionswindow.glade b/glade/optionswindow.glade
index 9733f7c..e0bedaa 100644
--- a/glade/optionswindow.glade
+++ b/glade/optionswindow.glade
@@ -193,7 +193,7 @@ Otherwise it will be disabled for better security.</property>
                       <object class="GtkImage" id="warning_image">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="stock">gtk-info</property>
+                        <property name="stock">gtk-dialog-warning</property>
                         <property name="icon-size">1</property>
                       </object>
                       <packing>
-- 
1.7.9.5


From cd8aa8f6493922a462831442f4e86f8e57168b18 Mon Sep 17 00:00:00 2001
From: kurono <andres.gomez@???>
Date: Sun, 8 Sep 2013 23:14:46 +0200
Subject: [PATCH] Display a warning icon on persistence unlocking failure
(Closes: #5332)

---
 glade/persistencewindow.glade |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/glade/persistencewindow.glade b/glade/persistencewindow.glade
index f4d8487..0b6f25f 100644
--- a/glade/persistencewindow.glade
+++ b/glade/persistencewindow.glade
@@ -300,7 +300,7 @@
                       <object class="GtkImage" id="warning_image">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="stock">gtk-info</property>
+                        <property name="stock">gtk-dialog-warning</property>
                         <property name="icon-size">1</property>
                       </object>
                       <packing>
-- 
1.7.9.5