Re: [Tails-dev] Fix in tails-greeter

Delete this message

Reply to this message
Autore: intrigeri
Data:  
To: The Tails public development discussion list
Oggetto: Re: [Tails-dev] Fix in tails-greeter
Hi,

Andres Gomez Ramirez wrote (08 Sep 2013 14:10:39 GMT) :
>> 2. I did not manage to confirm that this patch was working (boot
>> Tails, apply patch, restart gdm3 service, enter wrong persistence
>> passphrase).
>>
>> Once we're done with #5332, I just realized that we have the very same
>> problem in the greeter, with the administrator password, in the more
>> options dialog. I guess the same solution will be easy to apply there.


> mm so I misunderstood the requirement. I guess my fix was to the
> second bug you mention (related to greeter) and not to
> persistence :)


No, your patch was indeed well targeted to fix the bug you wanted :)

> I have not been able to test both bugs (as you mention boot Tails, apply patch,
> restart gdm3 service, enter wrong persistence pass phrase), restarting gdm3 does not
> work to me, It does not show me again the greeter or persistence
> initial menu.


It only works if you restart the gdm3 service from a text console
(tty1, etc. => CTRL-ALT-F1). If you run `service gdm3 restart' from X,
the stop action kills X, and then the Terminal, and then the start
action is not run.

Can you retry this way?

> I know how to test tails changes by creating an image
> (https://tails.boum.org/contribute/build/), but I'm confused about
> changes in software from different repositories (like greeter and
> persistence menu).


IMHO the easiest to test such patches during initial development is
often to add a patch to config/chroot_local-patches/ -- this nicely
works around the requirement to learn git-buildpackage, pbuilder &
friends :) Of course this only works for programs written in
interpreted languages, which happens to be the case for all our custom
programs shipped as .deb's.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc