Hi,
On Mon, 29 Apr 2013 19:23:20 +0200 intrigeri <intrigeri@???> wrote:
> Hi,
>
> Alan wrote (20 Apr 2013 23:39:38 GMT) :
> > While waiting for my builds to complete, I started to implement
> > this in feature/dont_autostart_iceweasel. It seems to basically
> > work, even if it needs more testing.
>
> Great!
Thanks.
> May you please update the ticket accordingly, so that it
> mentions the branch, and the next things to do are clear?
Yes, done.
> Or perhaps save the paperwork time to just finish it in time for the
> freeze if you prefer :)
>
Not sure I'll find time to do so, but perhaps there'll be a good
surprise. There's still the part "if we implement this, the profiling
script should probably be adapted to wait for another process." to do
and I didn't look at this yet.
> So, I had a quick look.
>
> May I suggest rebasing this feature branch on devel, rather than on
> a feature branch that was not merged yet, and whose history has been
> rewritten a few times already?
>
I can't do that easily, because I need d07288f "Abstract user
notification in a dedicated command" from that branch. I'll however
rebase on the latest version of the branch before asking for merge.
> > + /usr/bin/iceweasel "$@"
>
> I think this does not do what you think it does.
> It probably won't work when run with more than one argument,
> e.g. with `-new-tab URL'.
>
Are you sure? Man sh reads:
Special Parameters
@ Expands to the positional parameters, starting from
one. When the expansion occurs within double-quotes, each posi-
tional parameter expands as a separate argument. If there are no
positional parameters, the expansion of @ generates zero
arguments, even when @ is double-quoted. What this basically
means, for example, is if $1 is ``abc'' and $2 is ``def ghi'',
then "$@" expands to the two arguments: "abc" "def ghi"
Cheers
