Re: [Tails-dev] Please review bugfix/default_search_engines

Supprimer ce message

Répondre à ce message
Auteur: intrigeri
Date:  
À: The Tails public development discussion list
Sujet: Re: [Tails-dev] Please review bugfix/default_search_engines
Hi,

Ague Mill wrote (28 Sep 2012 10:12:33 GMT) :
> Done. Have a look at commit d3ebdba5.


Static review: I like it, but the use of "LANG" as a loop variable
name, which seems to be an unecessary risk to me, when a variable that
causes less side-effects could be used just as well. I'll change the
name, build a test ISO and merge soon :)

>> Added to the branch, then (commit 5ba8642).
> That did not work without another changes (commit 966f639).


Oops, sorry. Thanks a lot for catching my mistake.

Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc