Re: [Tails-dev] Please review bugfix/default_search_engines

On Thu, Sep 27, 2012 at 10:27:34AM +0200, intrigeri wrote:
> Ague Mill wrote (26 Sep 2012 10:43:31 GMT) :
> > Do you have any idea of how to do it better?
>
> > The only one that comes up to my mind is that we move all search
> > plugins somewhere else in the chroot tree and use a local hook to
> > add links in directories corresponding to given the installed
> > localization package set. It feels unnecessarily complicated.
>
> I agree it is a bit complicated, but I disagree on the "unnecessarily"
> part: I think it's the only way to fix this bug in a robust way, that
> is, to avoid seeing this bug re-appear, without us noticing, as soon
> as the list of iceweasel localization packages changes (e.g. if fr_BE
> appears, or if es_MX disappears). We don't want to test every language
> setting at release time for such regressions.

Done. Have a look at commit d3ebdba5.

> >> > f9d73a5 Be consistent when giving a locale to check.torproject.org
> >>
> >> OK, great. (FTR, the previous setting made sense when our syslinux
> >> menu allowed to pick "Portuguese", and that's all -- considering there
> >> are many more Portuguese speakers in Brasil than in Portugal.)
> >>
> >> I have a feeling that this commit is too much or too little, and
> >> causes a tiny regression for Brasilian users -- while we're at it, we
> >> should add support for pt-BR in our branding extension.
>
> > Yes, that'd be the way to go.
>
> Added to the branch, then (commit 5ba8642).

That did not work without another changes (commit 966f639).

--
Ague