Hi,
Max wrote (22 Oct 2011 08:03:52 GMT) :
> Btw, I've recently pushed version of tails-greeter with working
> console-setup. So there's no more regressions comparing to current
> approach.
I've quickly looked at your (welcome) recent changes, but not tested
them yet.
A few remarks:
+echo "${LIVE_USERNAME} ALL = NOPASSWD: /bin/setupcon" > "${SUDOERS}"
I don't see the point of creating this file at boot time. We should
just ship this file in the main Tails Git tree (in the tails-greeter
branch, to start with). Did I miss something?
- rm -f "${SUDOERS}"
+# rm -f "${SUDOERS}" # keep or we'll break console-setup procedure
... seems quite kludgy to me. There was good reasons to remove this
file in the first place. If we eventually happen to need to setup sudo
for various reasons at boot time (which I don't think is the case
currently, see above), we'll use different files in sudoers.d/ for
different purposes, rather than mixing things up in one file and
ending up doing things like that.
Also:
+echo "XKBMODEL=\"${TAILS_XKBMODEL}\"" > /etc/default/keyboard
I suggest appending to this file instead of overwriting it. If some
useful variable is set in there someday, that tails-greeter does not
take care of, we would be happy not to see it overwritten like that.
> However there's still GUI revamp and additional testing required
> before it can be included into public release.
For the record, what refrains you from merging the panel branch?
Anything left to fix or improve in there?
Or maybe you prefer if someone else does the review and merge step?
Bye,
--
intrigeri <intrigeri@???>
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
| Do not be trapped by the need to achieve anything.
| This way, you achieve everything.
