Re: [Tails-dev] tails-greeter review

Üzenet törlése

Válasz az üzenetre
Szerző: 
Dátum:  
CC: tails-dev
Tárgy: Re: [Tails-dev] tails-greeter review
15.08.2011 21:21, intrigeri пишет:

> The admin password feature seems on the right track, see the dedicated
> thread for a solution to the remaining blocking issue.


Yepp, working on the fix.

> 1. Alt + Shift
>
> I don't understand what "Use Alt + Shift to switch layouts" means.
> It seems pressing this shortcut is not needed, which is great.


Well, that's true but it's available - I've tried to mimic gdm's behavior here: by
pressing alt+shift you can change layout.

> 2. Pre-selected locale
>
> xx_XX locale, when available, should be the default when the xx
> language is selected. E.g. when choosing say the "Deutsch" language, I
> think de_DE should be the pre-selected locale, instead of the first
> that comes in lexical order (de_AT).


Fixed in git.

> 3. Widgets and usability
>
> As I already said, the widget used to select a language is a pain to
> use. If it's that hard to use a more appropriate widget, I think we
> should at the very least allow the user to move the focused line by
> typing the first letter of the desired language name.


Could you point me particular glade file with this widget?
I was unable to find it. Also I do not see scrollable widget in glade itself which is
weird. Maybe you can send me dummy glade file with this scrollable list widget and
store so I can try to integrate it?

> Also, I still think it would be much better to just copy the widget
> used by gdm-simple-greeter to allow choosing the language and locale
> at the same time: asking Tails users to choose among strings like
> "en_MX" is not an option, that's why "Español (México)" is much
> better.


Ok, I'll take a look.

> 4. Limited layout choice
>
> Seems like it's not possible to choose, say, the "Deutsch" language
> and a keyboard layout that is not a German-based one. It's great to
> have the most probable keyboard layouts easy to reach, but it's not
> that great to be prevented to use, say, a qwerty keyboard layout.
>
> The keyboard layout UI in the gdm-simple-greeter panel is great I
> think: the same layouts that are currently available in tails-greeter
> for a given language would be part of the default list, and the
> "Other" button would allow choosing another one as well as variants.


I don't understand it at all. After I've chosen 'de' layout I still can switch back
and forth with alt+shift to\from 'us' layout. Just like in gdm.

> 5. Phrasing and UI
>
> I'd replace "Enter here a password that will be asked to grant
> administrator rights." with "Optionally enter an administration
> password."
>
> Don't put ":" at the end of text labels ("Language:").
>
> Adding some margin between widgets, and between window border and
> widgets, would be a great idea I think.
>
> Why is the current layout displayed inside square brackets (like
> this: [XX])? Feels weird.


Should be fixed in git. Although I'm not sure about margins - if they are not wide
enough you can push adjusted glade file into git.

cheers,
Max.