intrigeri <intrigeri@???> writes:
> Hi,
>
> Zen Fu (2021-04-07):
>> Another thing that could be explicitely documented is whether a reviewer
>> should/could merge code after a review or not. This may differ from team
>> to team because not always the assignee has privileges to merge. Maybe
>> we could explicitely say when we expect the reviewer to merge? Or maybe
>> the MR should then be re-assigned to someone that can actually merge? I
>> don't think we need to make this very complex, but as it's a question
>> that has popped up for me I'm raising it here.
>
> The intention of our current doc is to cover this case:
> https://tails.boum.org/contribute/merge_policy/#merge
>
> Is it unclear, buggy, or lacking?
I don't think so, the doc seems to clearly indicate that reviewers
should merge if they have the rights to.
Maybe what's unclear is the phrase from the first e-mail in this thread,
because "bringing the MR to completion" may or may not include merging
it, depending on the Reviewer's rights.
But it's all clear for me now, I don't think we need to do further
discussions or changes now.
Thanks for helping clarify this!
