Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab…

Nachricht löschen

Nachricht beantworten
Autor: Sandro Knauß
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab MRs
Hi,

I like the request.

But there is issue - users need more privileges to set the reviewer field. That
happens for me, that I cannot set the reviewer for MR at the puppet-tails
repo. So I need to ping a sysadmin to set themselves as reviewer (as part of
the translation plattfom work is done in the puppet-tails repo). This bug
stops using the "Reviewer" feature for those MR ;) But properly this
permission to set/change the reviewer field cannot set individually.

For most cases that is not an issue - As a random user creates a MR with no
reivewer assigned and one of the group explictitly picks that MR to review it.
The group members has enough privileges to set the reviewer field.

hefee

On Dienstag, 6. April 2021 12:05:04 CEST intrigeri wrote:
> Hi,
>
> A few months ago, GitLab Inc. open-sourced the "Reviewer" feature for
> Merge Requests.
>
> This allows keeping track _independently_ of:
>
> - Who's responsible for bringing the MR to completion: the Assignee.
>
> - Who's responsible for reviewing the MR: the Reviewer.
>
> Some teams have been experimenting with this workflow in the last
> months, instead of our previous — and still documented — workflow in
> which we would assign a MR to its Reviewer. The feedback that came my
> way has been entirely positive so far.
>
> I think it's now time to make a decision and adjust either our
> documented process or our actual practices to match it.
>
> I propose we start using the "Reviewer" field in MRs, as described
> above and in the GitLab documentation.
>
> Any issue with that?
>
> Please share your thoughts by April 20.
>
> I'll update our doc once we're reached a conclusion, whichever it is.
>
> Cheers!
> _______________________________________________
> Tails-dev mailing list
> Tails-dev@???
> https://www.autistici.org/mailman/listinfo/tails-dev
> To unsubscribe from this list, send an empty email to
> Tails-dev-unsubscribe@???.