Re: [Tails-dev] Finalizing MacBook 2015 support

Delete this message

Reply to this message
Author: Marco Betschart
Date:  
To: The Tails public development discussion list
Subject: Re: [Tails-dev] Finalizing MacBook 2015 support
@intrigeri thanks for pointing me towards the right direction. The *.iso finally built and Tails now works perfectly on my MacBook 12“ 2015! 🎉
I’d love to see the changes merged into upstream; what would be the right approach to accomplish this? Sending a merge request @GitLab?

Here are all the changes which were necessary:
https://gitlab.com/marbetschar/tails/commit/3bfe4fdc73ebb2436a719a283ce63a815fc72668 <https://gitlab.com/marbetschar/tails/commit/3bfe4fdc73ebb2436a719a283ce63a815fc72668>


> Am 11.06.2018 um 20:18 schrieb intrigeri <intrigeri@???>:
>
> marco@???:
>> @intrigeri good catch; seems to be a symlink issue.
>
> I don't think so.
>
>> below the build log output.
>
> Thanks!
>
>> Building VirtualBox guest modules
>> + . /usr/share/amnesia/build/variables
>> + KERNEL_VERSION=4.15.0-3
>> + KERNEL_SOURCE_VERSION=4.15
>> + LB_DISTRIBUTION=stretch
>> + POTFILES_DOT_IN=/etc/skel/Desktop/Report_an_error.desktop.in
>> /etc/skel/Desktop/tails-documentation.desktop.in
>> /usr/share/applications/tails-documentation.desktop.in
>> /usr/share/applications/tails-about.desktop.in
>> /usr/share/applications/tor-browser.desktop.in
>> /usr/share/applications/unsafe-browser.desktop.in
>> /usr/share/desktop-directories/Tails.directory.in
>> /usr/share/polkit-1/actions/org.boum.tails.root-terminal.policy.in
>> + . /usr/local/lib/tails-shell-library/build.sh
>> + . /usr/local/lib/tails-shell-library/common.sh
>> + ensure_hook_dependency_is_installed dkms
>> + shift
>> + echo dkms
>> + grep -q --extended-regexp ^[a-z0-9.+-]+$
>> + is_package_installed dkms
>> + local package_name package_status
>> + package_name=dkms
>> + no_abort dpkg-query --show --showformat=${db:Status-Status} dkms
>> + package_status=installed
>> + [ installed = installed ]
>> + continue
>> + [ -z ]
>> + return
>> + ensure_hook_dependency_is_installed virtualbox-guest-dkms
>> + shift
>
> So the virtualbox-guest-dkms package was installed but no module was
> built. I think that's explained by this comment:
>
> "# Any -dkms package must be installed *after* dkms to be properly registered"
>
> … which is the case usually (my build logs say that dkms is installed
> by the 50-dkms hook), but apparently your new hook makes this
> requirement not satisfied anymore. I suggest you add your code to
> some relevant place in 50-dkms instead of creating a new hook that
> runs earlier.
> _______________________________________________
> Tails-dev mailing list
> Tails-dev@???
> https://mailman.boum.org/listinfo/tails-dev
> To unsubscribe from this list, send an empty email to Tails-dev-unsubscribe@???.