Re: [Tails-dev] Review of verification-extension

Delete this message

Reply to this message
Autor: Uzair Farooq
Data:  
Para: u
CC: The Tails public development discussion list
Assunto: Re: [Tails-dev] Review of verification-extension
> Hm, but if it's not needed, why don't we remove this piece of code? Can you
try? Also make sure that the input we receive here can be trusted.

I think it's meant to remove comments from the end of a line e.g.

build-target: amd64 # some comments here

This might be useful if you add some comments to the file in future.

On Fri, Nov 24, 2017 at 1:49 PM, u <u@???> wrote:

> Hi,
>
> Uzair Farooq:
>
> >> - What kind of comments does this remove:
> >>    44 data = data.replace(/^[^'"]*#.*/gm, ''); // remove most comments
> >>    I don't see any in
> >> https://tails.boum.org/install/v1/Tails/amd64/stable/latest.yml

> >
> > We copied it from old extension:
> > https://git-tails.immerda.ch/ma1/download-and-verify-
> extension/tree/tails-download-and-verify/lib/df.js
>
> Hm, but if it's not needed, why don't we remove this piece of code? Can
> you try? Also make sure that the input we receive here can be trusted.
>
> Thanks for the other modifications :)
>
> u.
>