Re: [Tails-dev] Verification extension [was: HTML prototype …

Üzenet törlése

Válasz az üzenetre
Szerző: Uzair Farooq
Dátum:  
Címzett: u
CC: The Tails public development discussion list
Tárgy: Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]
>When the extension gets installed, the page is not updated to show "Verify
download...". See this screencast:

> https://dl.poivron.org/maad2a3jiuqdu3k3wjbf-dirqyvooctlkem57


> Uzair: Could you help me fix that? Is it something that should be fixed

in the extension or on the page?

Fixed, extension will change the view to "Verify download..."

> - contentscript/verify.js:
> - fetchConf(): please wrap the regexps.


Not sure what you mean by this. Do you want me to convert them to 'new
Regex()' format?

> - manifest.json:
>  -  "permissions": [
>         "http://*/*",
>     -> please deactivate HTTP. We only want to download over HTTPS.


Fixed this. Also, I removed 'http://*/*' permission and added only
tails.boum.org permission as we don't require permission for all sites.

On Mon, Nov 13, 2017 at 9:44 PM, u <u@???> wrote:

> Hello!
>
> congrats on your work on the extension!
>
> I reviewed the code a little bit and I have some requests which should
> be fixed beofore the release please:
>
> - contentscript/verify.js:
> - fetchConf(): please wrap the regexps.
>
> - manifest.json:
>   -  "permissions": [
>          "http://*/*",
>      -> please deactivate HTTP. We only want to download over HTTPS.

>
> I also have some more requests which are less urgent to fix.
> Let's talk about these other issues in a separate thread / or tickets. I
> will ask sajolida what the preferred way to report this is.
>
> Cheers!
> u.
>