Re: [Tails-dev] Verification extension [was: HTML prototype …

Supprimer ce message

Répondre à ce message
Auteur: u
Date:  
À: tails-dev, Uzair Farooq
Sujet: Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]
Hello!

congrats on your work on the extension!

I reviewed the code a little bit and I have some requests which should
be fixed beofore the release please:

- contentscript/verify.js:
- fetchConf(): please wrap the regexps.

- manifest.json:
  -  "permissions": [
         "http://*/*",
     -> please deactivate HTTP. We only want to download over HTTPS.


I also have some more requests which are less urgent to fix.
Let's talk about these other issues in a separate thread / or tickets. I
will ask sajolida what the preferred way to report this is.

Cheers!
u.