Re: [Tails-dev] CSS fixes

Poista viesti

Vastaa
Lähettäjä: u
Päiväys:  
Vastaanottaja: tails-dev
Aihe: Re: [Tails-dev] CSS fixes
Hi!

intrigeri:
> Hi,
>
> u:
>> intrigeri:
>>> u:
>>> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
>>> border-bottom to the links to translations, while the commit message
>>> says "Make other languages stick to the correct place", so perhaps
>>> that was not intended?


> I do see a border, both in Chromium 60.0.3112.78-1 and Firefox
> 52.3.0esr-2.
>
>> I don't see that border
>
> Weird. So either your website build system / process is buggy, or mine
> is. Unless that's because we run different versions of ikiwiki. I have
> the one from sid.


> Firefox developer tools tell me that the black border comes from
> ikiwiki's style.css, that reads:
>
> .pageheader #otherlanguages {
>         border-bottom: 1px solid #000;
> }


Interesting. This did not show up when I compiled ikiwiki.
Anyhow, I fixed that now. Thanks for the screenshot.

> That was last changed on 2009-08-15 so I doubt the "we run different


>> I'll convert all tabs to four spaces. Done.
>
> Thanks! Now I see a new kind of inconsistencies though: 4-spaces vs.
> 8-spaces indentation, sometimes in the same block.


Fixed too and pushed to the same branch and my repository.
> I'm not commenting on each individual fix you did as a follow-up to my
> initial review, but they all look good to me :)


Good.

Ready for another round of reviewing? :)

Cheers!
u.