Autor: u Data: A: tails-dev Assumpte: Re: [Tails-dev] CSS fixes
Hi!
intrigeri: > u:
> Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am
> at ease with.
Very good :)
> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
> border-bottom to the links to translations, while the commit message
> says "Make other languages stick to the correct place", so perhaps
> that was not intended?
Uh, "it *seems* to add a black border-bottom" or it does add a border?
I don't see that border and git show
d2d5d8d76449eab066bb1e992724d13b0b24496f shows indeed that I removed a
border, but there is no border which this div inherits, and thus, this
line is not necessary.
Care to send me a screenshot?
> Please use ./wiki/src/contribute/how/documentation/compress-image.sh
> on the new images and rewrite history (so we don't import two
> versions of the same image into .git :)
Ack.
Ok, that's done, rather poorly though, it mixes part of CSS commit with
these images. I'm not the queen of rewriting history apparently! But
well. I'll do better next time.
> It looks like lib/banner.png is not used anymore. Remove it?
Right! Done.
> I see a few indentation (e.g. tabs vs. spaces) inconsistencies
> introduced by this branch.
I'll convert all tabs to four spaces. Done.
> While you're doing house-cleaning, I see "0,5s" transitions in a few
> places you don't touch. Is the comma supported there (as opposed to
> "0.5s") or do we have code that doesn't do what one might think? :)
No, a comma is indeed not supported, so I will clean this. Done.
>> I would appreciate if this
>> could be merged before starting the donation campaign, that is.. quite
>> soonish :)
>
> I've built the website and noticed no obvious problem, so once these
> issues have been fixed I'm happy to merge, unless you think it's more
> reasonable to let sajolida review first. Now, something more specific
> than "quite soonish" would help me prioritize my work :)
Soonish was supposed to mean that I'd like to merge this into my
donation banner branch, which will also have to be reviewed at some
point early in October latest delay.
%0A>%20%0A>%20>%20commit%20d2d5d8d76449eab066bb1e992724d13b0b24496f%20seems%20to%20add%20a%20black%0A>%20>%20border-bottom%20to%20the%20links%20to%20translations,%20while%20the%20commit%20message%0A>%20>%20says%20%22Make%20other%20languages%20stick%20to%20the%20correct%20place%22,%20so%20perhaps%0A>%20>%20that%20was%20not%20intended?%0A>%20%0A>%20Uh,%20%22it%20*seems*%20to%20add%20a%20black%20border-bottom%22%20or%20it%20does%20add%20a%20border?%0A>%20%0A>%20I%20don't%20see%20that%20border%20and%20git%20show%0A>%20d2d5d8d76449eab066bb1e992724d13b0b24496f%20shows%20indeed%20that%20I%20removed%20a%0A>%20border,%20but%20there%20is%20no%20border%20which%20this%20div%20inherits,%20and%20thus,%20this%0A>%20line%20is%20not%20necessary.%0A>%20Care%20to%20send%20me%20a%20screenshot?%0A>%20%0A>%20>%20Please%20use%20./wiki/src/contribute/how/documentation/compress-image.sh%0A>%20>%20on%20the%20new%20images%20and%20rewrite%20history%20(so%20we%20don't%20import%20two%0A>%20>%20versions%20of%20the%20same%20image%20into%20.git%20:)%0A>%20%0A>%20Ack.%0A>%20%0A>%20Ok,%20that's%20done,%20rather%20poorly%20though,%20it%20mixes%20part%20of%20CSS%20commit%20with%0A>%20these%20images.%20I'm%20not%20the%20queen%20of%20rewriting%20history%20apparently!%20But%0A>%20well.%20I'll%20do%20better%20next%20time.%0A>%20%0A>%20>%20It%20looks%20like%20lib/banner.png%20is%20not%20used%20anymore.%20Remove%20it?%0A>%20%0A>%20Right!%20Done.%0A>%20%0A>%20>%20I%20see%20a%20few%20indentation%20(e.g.%20tabs%20vs.%20spaces)%20inconsistencies%0A>%20>%20introduced%20by%20this%20branch.%0A>%20%0A>%20I'll%20convert%20all%20tabs%20to%20four%20spaces.%20Done.%0A>%20%0A>%20>%20While%20you're%20doing%20house-cleaning,%20I%20see%20%220,5s%22%20transitions%20in%20a%20few%0A>%20>%20places%20you%20don't%20touch.%20Is%20the%20comma%20supported%20there%20(as%20opposed%20to%0A>%20>%20%220.5s%22)%20or%20do%20we%20have%20code%20that%20doesn't%20do%20what%20one%20might%20think?%20:)%0A>%20%0A>%20No,%20a%20comma%20is%20indeed%20not%20supported,%20so%20I%20will%20clean%20this.%20Done.%0A>%20%0A>%20>>%20I%20would%20appreciate%20if%20this%0A>%20>>%20could%20be%20merged%20before%20starting%20the%20donation%20campaign,%20that%20is..%20quite%0A>%20>>%20soonish%20:)%0A>%20>%20%0A>%20>%20I've%20built%20the%20website%20and%20noticed%20no%20obvious%20problem,%20so%20once%20these%0A>%20>%20issues%20have%20been%20fixed%20I'm%20happy%20to%20merge,%20unless%20you%20think%20it's%20more%0A>%20>%20reasonable%20to%20let%20sajolida%20review%20first.%20Now,%20something%20more%20specific%0A>%20>%20than%20%22quite%20soonish%22%20would%20help%20me%20prioritize%20my%20work%20:)%0A>%20%0A>%20Soonish%20was%20supposed%20to%20mean%20that%20I'd%20like%20to%20merge%20this%20into%20my%0A>%20donation%20banner%20branch,%20which%20will%20also%20have%20to%20be%20reviewed%20at%20some%0A>%20point%20early%20in%20October%20latest%20delay.%0A>%20%0A>%20So%20the%20earlier%20the%20better,%20without%20stress%20though.%0A>%20%0A>%20Cheers!%0A>%20u.%0A>%20%0A>%20 "Reply to this message")