Author: intrigeri Date: To: The Tails public development discussion list Subject: Re: [Tails-dev] CSS fixes
u: > Hi! > for the future donation campaign I need a clean start..
> That's why I implemented some small CSS fixes. Please review and merge: > 451f:tails/feature/smallCSSfixes
Thanks!
Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am
at ease with.
commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
border-bottom to the links to translations, while the commit message
says "Make other languages stick to the correct place", so perhaps
that was not intended?
Please use ./wiki/src/contribute/how/documentation/compress-image.sh
on the new images and rewrite history (so we don't import two
versions of the same image into .git :)
It looks like lib/banner.png is not used anymore. Remove it?
I see a few indentation (e.g. tabs vs. spaces) inconsistencies
introduced by this branch.
While you're doing house-cleaning, I see "0,5s" transitions in a few
places you don't touch. Is the comma supported there (as opposed to
"0.5s") or do we have code that doesn't do what one might think? :)
> I would appreciate if this
> could be merged before starting the donation campaign, that is.. quite
> soonish :)
I've built the website and noticed no obvious problem, so once these
issues have been fixed I'm happy to merge, unless you think it's more
reasonable to let sajolida review first. Now, something more specific
than "quite soonish" would help me prioritize my work :)
%0A>%20%0A>%20It%20looks%20like%20lib/banner.png%20is%20not%20used%20anymore.%20Remove%20it?%0A>%20%0A>%20I%20see%20a%20few%20indentation%20(e.g.%20tabs%20vs.%20spaces)%20inconsistencies%0A>%20introduced%20by%20this%20branch.%0A>%20%0A>%20While%20you're%20doing%20house-cleaning,%20I%20see%20%220,5s%22%20transitions%20in%20a%20few%0A>%20places%20you%20don't%20touch.%20Is%20the%20comma%20supported%20there%20(as%20opposed%20to%0A>%20%220.5s%22)%20or%20do%20we%20have%20code%20that%20doesn't%20do%20what%20one%20might%20think?%20:)%0A>%20%0A>%20>%20I%20would%20appreciate%20if%20this%0A>%20>%20could%20be%20merged%20before%20starting%20the%20donation%20campaign,%20that%20is..%20quite%0A>%20>%20soonish%20:)%0A>%20%0A>%20I've%20built%20the%20website%20and%20noticed%20no%20obvious%20problem,%20so%20once%20these%0A>%20issues%20have%20been%20fixed%20I'm%20happy%20to%20merge,%20unless%20you%20think%20it's%20more%0A>%20reasonable%20to%20let%20sajolida%20review%20first.%20Now,%20something%20more%20specific%0A>%20than%20%22quite%20soonish%22%20would%20help%20me%20prioritize%20my%20work%20:)%0A>%20%0A>%20Cheers!%0A>%20--%20%0A>%20intrigeri%0A>%20%0A>%20 "Reply to this message")