kurono:
> On 03/14/2017 06:55 PM, sajolida wrote:
>
>> I did that in #12344. If you don't mind reviewing it.
>
> Done, check the ticket.
I added your proposals and merged.
>> I'm fine with that. I rewrote a bit the message with 11ebad8.
>>
>> Also, since we're there, what about allowing the user to select the ISO
>> image from this dialog to be more forgiving?
>>
>> It would allow her to solve the problem directly from the error message
>> and avoid her to have to go back to the main window and figure out what
>> this is referring to.
>>
>> What about, instead of having only an "Ok" button, having:
>>
>> [Cancel] [Select ISO image...]
>>
>> But that's optional and you can create a ticket to do that later on if
>> you prefer.
>
> I have created Feature #12435 to track this request.
Excellent! We can deal with that later on.
>> Some more remarks:
>>
>> 1. If I start Tails Installer without a target USB stick and then plug
>> it in, the interface gets widely resized. It not a serious problem but
>> looks unpolished. See before.png and after.png.
>>
>> Also, the description of the USB stick in the main window and in the
>> confirmation dialog is different. See confirm.png. I prefer the one in
>> the confirmation dialog because it is shorter while still having all the
>> necessary info (vendor, size, and model) but without the long number
>> that is displayed in the main window. Maybe getting rid of the long
>> number in the main window would also help solving the resizing issue.
>> What do you think?
>
> ok cool, I have left the same short message for both cases.
Ack!
>> 2. By default the file selector is too small to display the full name of
>> the ISO image and only displays "tails-...".
>>
>> If I am playing with different versions (for example when upgrading) I
>> would like to have some feedback from the main window about the ISO
>> image that I selected.
>>
>> Would it work to make the file selector wide enough to handle our usual
>> filename length: ~22 characters for "tails-archh-x.yy.z.iso"?
>
> I have established a fixed length for the ISO label.
>From 0c8f3fc I understand that you set this to 15 chars.
In my tests this matched (with the new "amd64" architecture):
tails-amd64-x.y.
And I was still missing the minor version.
I proposed 22 chars in my previous email but apparently the minimum
chars to fit "tails-amd64-3.12.3.iso" is 17, probably due to the
non-monospace fonts.
So I really want to have a minimum of 17 but then I don't care much
about the exact value.
Also, right now if I make the window wider, the file chooser doesn't get
wider. That would be another way of preventing having the filename
partially hidden. Feel free to do this if that's easy :)
>> 3. In the confirmation dialog before installation or upgrade, I would
>> love to have, instead of the [No] [Yes] buttons:
>>
>> [Cancel] [Install]
>>
>> or
>>
>> [Cancel] [Upgrade]
>>
>> I'm myself always a bit scared when upgrading a Tails USB stick and this
>> would be reassuring (even if we're already solving this problem is other
>> ways with the rest of your work).
>
> I have assigned Feature #11501 to me.
Ok.
>> 4. Would it be easy to fix the minor alignment issues on the right,
>> especially with the links? See alignment.png. Otherwise forget it :)
>
> I couldn't find how to do it :P
Fair enough :)
>> 5. Would it be possible to display "The persistent storage on this USB
>> stick will be preserved." only if there actually is a persistent
>> storage? But if that requires tweaking the backend we can create a
>> ticket to do that later on.
>
> Done.
Ack!
>> 6. If I plug two USB sticks, one with Tails and one without, and switch
>> from Upgrade to Install and then back to Upgrade, then the Reinstall
>> link disappears.
>
> Fixed.
Switching between "Install" and "Upgrade" is still broken for me :(
If it's what you meant to fix with 885be99, maybe there was a
misunderstanding. The problem is that when plug two USB stick (one with
Tails and one without Tails) and switching between the two in as target
USB stick, then the Install button doesn't change to Upgrade.
>> 7. I rephrase the confirmation dialog quite a bit with e1908d0. Tell me
>> what you thing. Especially since I'm tweaking Gtk a bit to display an
>> empty new line. I don't know if that's good or if it's the proper way to
>> do that.
>
> It looks fine to me.
Ok :)
>> But hey, we're almost there and I'm really excited to see this finally
>> tackled in Tails Installer which is pretty much the first piece of
>> software our users have to interact with. Good job!
>
> Great :D
So we only have two small issues remaining:
2. The chars of the file chooser
6. The switching between Install and Upgrade.
I can do the patch for #2 but not for #6 so unfortunately, I have to
reassign this to you again :(
%20but%20without%20the%20long%20number%0A>%20>>%20that%20is%20displayed%20in%20the%20main%20window.%20Maybe%20getting%20rid%20of%20the%20long%0A>%20>>%20number%20in%20the%20main%20window%20would%20also%20help%20solving%20the%20resizing%20issue.%0A>%20>>%20What%20do%20you%20think?%0A>%20>%20%0A>%20>%20ok%20cool,%20I%20have%20left%20the%20same%20short%20message%20for%20both%20cases.%0A>%20%0A>%20Ack!%0A>%20%0A>%20>>%202.%20By%20default%20the%20file%20selector%20is%20too%20small%20to%20display%20the%20full%20name%20of%0A>%20>>%20the%20ISO%20image%20and%20only%20displays%20%22tails-...%22.%0A>%20>>%0A>%20>>%20If%20I%20am%20playing%20with%20different%20versions%20(for%20example%20when%20upgrading)%20I%0A>%20>>%20would%20like%20to%20have%20some%20feedback%20from%20the%20main%20window%20about%20the%20ISO%0A>%20>>%20image%20that%20I%20selected.%0A>%20>>%0A>%20>>%20Would%20it%20work%20to%20make%20the%20file%20selector%20wide%20enough%20to%20handle%20our%20usual%0A>%20>>%20filename%20length:%20~22%20characters%20for%20%22tails-archh-x.yy.z.iso%22?%0A>%20>%20%0A>%20>%20I%20have%20established%20a%20fixed%20length%20for%20the%20ISO%20label.%0A>%20%0A>%20>From%200c8f3fc%20I%20understand%20that%20you%20set%20this%20to%2015%20chars.%0A>%20%0A>%20In%20my%20tests%20this%20matched%20(with%20the%20new%20%22amd64%22%20architecture):%0A>%20%0A>%20%0A>%20And%20I%20was%20still%20missing%20the%20minor%20version.%0A>%20%0A>%20I%20proposed%2022%20chars%20in%20my%20previous%20email%20but%20apparently%20the%20minimum%0A>%20chars%20to%20fit%20%22tails-amd64-3.12.3.iso%22%20is%2017,%20probably%20due%20to%20the%0A>%20non-monospace%20fonts.%0A>%20%0A>%20So%20I%20really%20want%20to%20have%20a%20minimum%20of%2017%20but%20then%20I%20don't%20care%20much%0A>%20about%20the%20exact%20value.%0A>%20%0A>%20Also,%20right%20now%20if%20I%20make%20the%20window%20wider,%20the%20file%20chooser%20doesn't%20get%0A>%20wider.%20That%20would%20be%20another%20way%20of%20preventing%20having%20the%20filename%0A>%20partially%20hidden.%20Feel%20free%20to%20do%20this%20if%20that's%20easy%20:)%0A>%20%0A>%20>>%203.%20In%20the%20confirmation%20dialog%20before%20installation%20or%20upgrade,%20I%20would%0A>%20>>%20love%20to%20have,%20instead%20of%20the%20%5BNo%5D%20%5BYes%5D%20buttons:%0A>%20>>%0A>%20>>%0A>%20>>%20or%0A>%20>>%0A>%20>>%0A>%20>>%20I'm%20myself%20always%20a%20bit%20scared%20when%20upgrading%20a%20Tails%20USB%20stick%20and%20this%0A>%20>>%20would%20be%20reassuring%20(even%20if%20we're%20already%20solving%20this%20problem%20is%20other%0A>%20>>%20ways%20with%20the%20rest%20of%20your%20work).%0A>%20>%20%0A>%20>%20I%20have%20assigned%20Feature%20#11501%20to%20me.%0A>%20%0A>%20Ok.%0A>%20%0A>%20>>%204.%20Would%20it%20be%20easy%20to%20fix%20the%20minor%20alignment%20issues%20on%20the%20right,%0A>%20>>%20especially%20with%20the%20links?%20See%20alignment.png.%20Otherwise%20forget%20it%20:)%0A>%20>%20%0A>%20>%20I%20couldn't%20find%20how%20to%20do%20it%20:P%0A>%20%0A>%20Fair%20enough%20:)%0A>%20%0A>%20>>%205.%20Would%20it%20be%20possible%20to%20display%20%22The%20persistent%20storage%20on%20this%20USB%0A>%20>>%20stick%20will%20be%20preserved.%22%20only%20if%20there%20actually%20is%20a%20persistent%0A>%20>>%20storage?%20But%20if%20that%20requires%20tweaking%20the%20backend%20we%20can%20create%20a%0A>%20>>%20ticket%20to%20do%20that%20later%20on.%0A>%20>%20%0A>%20>%20Done.%0A>%20%0A>%20Ack!%0A>%20%0A>%20>>%206.%20If%20I%20plug%20two%20USB%20sticks,%20one%20with%20Tails%20and%20one%20without,%20and%20switch%0A>%20>>%20from%20Upgrade%20to%20Install%20and%20then%20back%20to%20Upgrade,%20then%20the%20Reinstall%0A>%20>>%20link%20disappears.%0A>%20>%20%0A>%20>%20Fixed.%0A>%20%0A>%20Switching%20between%20%22Install%22%20and%20%22Upgrade%22%20is%20still%20broken%20for%20me%20:(%0A>%20%0A>%20If%20it's%20what%20you%20meant%20to%20fix%20with%20885be99,%20maybe%20there%20was%20a%0A>%20misunderstanding.%20The%20problem%20is%20that%20when%20plug%20two%20USB%20stick%20(one%20with%0A>%20Tails%20and%20one%20without%20Tails)%20and%20switching%20between%20the%20two%20in%20as%20target%0A>%20USB%20stick,%20then%20the%20Install%20button%20doesn't%20change%20to%20Upgrade.%0A>%20%0A>%20>>%207.%20I%20rephrase%20the%20confirmation%20dialog%20quite%20a%20bit%20with%20e1908d0.%20Tell%20me%0A>%20>>%20what%20you%20thing.%20Especially%20since%20I'm%20tweaking%20Gtk%20a%20bit%20to%20display%20an%0A>%20>>%20empty%20new%20line.%20I%20don't%20know%20if%20that's%20good%20or%20if%20it's%20the%20proper%20way%20to%0A>%20>>%20do%20that.%0A>%20>%20%0A>%20>%20It%20looks%20fine%20to%20me.%0A>%20%0A>%20Ok%20:)%0A>%20%0A>%20>>%20But%20hey,%20we're%20almost%20there%20and%20I'm%20really%20excited%20to%20see%20this%20finally%0A>%20>>%20tackled%20in%20Tails%20Installer%20which%20is%20pretty%20much%20the%20first%20piece%20of%0A>%20>>%20software%20our%20users%20have%20to%20interact%20with.%20Good%20job!%0A>%20>%20%0A>%20>%20Great%20:D%0A>%20%0A>%20So%20we%20only%20have%20two%20small%20issues%20remaining:%0A>%20%0A>%202.%20The%20chars%20of%20the%20file%20chooser%0A>%206.%20The%20switching%20between%20Install%20and%20Upgrade.%0A>%20%0A>%20I%20can%20do%20the%20patch%20for%20#2%20but%20not%20for%20#6%20so%20unfortunately,%20I%20have%20to%0A>%20reassign%20this%20to%20you%20again%20:(%0A>%20%0A>%20 "Reply to this message")