Re: [Tails-dev] [review'n'merge:1.3] feature/5525-sandbox-we…

Poista viesti

Vastaa
Lähettäjä: intrigeri
Päiväys:  
Vastaanottaja: The Tails public development discussion list
Aihe: Re: [Tails-dev] [review'n'merge:1.3] feature/5525-sandbox-web-browser
intrigeri wrote (10 Feb 2015 16:52:08 GMT) :
> anonym wrote (10 Feb 2015 15:29:58 GMT) :
>> I'd suggest the following so a special case doesn't have to be added for
>> each key:


> Looks good. I admit I was too lazy to learn Ruby's meta-programming
> features, although this idea did occur to me. Going to test it locally
> and add this to the branch.


Unfortunately, it doesn't work:

    And I press the "ENTER" key                                                  # features/step_definitions/common_steps.rb:810
      Fail: unknown method name `method_defined?' (RuntimeError)
      ./features/step_definitions/common_steps.rb:812:in `method_missing'


I suspect that the crazy rjb stuff we're doing doesn't produce modules
(classes) that inherit from the Module module. So I had to go back to
my initial implementation.

>> Lastly, one scenario fails consistently for me:


>>   Scenario: Importing an OpenPGP key from website
>> [...]
>>     Then I see "KeyImportedNotification.png" after at most 10 seconds
>>       FindFailed: can not find KeyImportedNotification.png on the screen.


>> The failure screen shot still shows the "Save file" dialog so it seems
>> the ENTER key press was lost. I guess we have to click the dialog's OK
>> button instead.


> OK, will look into it right now.


Implemented what you suggest, still works for me. Better for you?

Cheers!
--
intrigeri