On 01/15/2015 18:29, sycamoreone wrote: > Hi spriver,
>
> spriver:
>> I reviewed them both and made some smaller changes. Someone
>> should have a look and then we can pull ;)
>>
>> Files are
>>
>> wiki/src/news/version_1.2.3.de.po
>> wiki/src/security/Numerous_security_holes_in_1.2.2.de.po
>>
>> My repo as usual
>>
>> https://github.com/spriver/tails >>
>> And the branch is
>>
>> news123
>
> thanks for doing the review. A few questions: I can't see on what
> branch your branch news123 is based on. Also it doesn't contain the
> original commits 6c56582681affd5 from sycamoreone/stable so it is
> hard for me to see what changed.
>
> The workflow I would suggest for reviews would be something along
> the lines of
>
> git checkout -b review_news123 torsocks git pull
> https://git-tails.immerda.ch/sycamoreone/tails stable [fix
> translations and git add] git commit -m "Small changes to ..."
>
> In this way one would only have to look at the last commit to see
> your fixes instead of having to re-check everything.
>
> Does this make sense?
>
