Re: [Tails-dev] [review'n'merge: 1.2.1] bugfix/8158-stacked-…

Üzenet törlése

Válasz az üzenetre
Szerző: intrigeri
Dátum:  
Címzett: The Tails public development discussion list
Tárgy: Re: [Tails-dev] [review'n'merge: 1.2.1] bugfix/8158-stacked-rootfs-vs-chroot-browsers
Hi,

anonym wrote (21 Oct 2014 13:26:46 GMT) :
> This branch fixes bugs #8152 and #8158 and is based on a patch
> contributed by sanic (Thanks again!). Since I had to re-write the patch
> a bit I suppose it should be review'n'merged by someone else, so please
> review'n'merge into stable and devel!


> As for testing, see #8158 (comment 13) for what I did.


The code looks good.

I admit I was too lazy to test it with a 1.3~something home-made IUK,
and you've done it already, so what I've done is only:

  * installed 1.1.2, incrementally upgraded to 1.2, rebooted, applied
    the patch from commit 568e48 *live*, and run the I2P and Unsafe
    browsers; it would have been good 


  * with an ISO built from stable +
    bugfix/8158-stacked-rootfs-vs-chroot-browsers, verified that both
    I2P and Unsafe browsers can start (that is, confirmed that no
    regression is brought by this branch in the usecase when one has
    *not* upgraded Tails incrementally)


=> merged!

Cheers!
--
intrigeri