02/10/14 11:23, intrigeri wrote:
> Hi,
>
> great to see some initial work on the migration to FF31 in that
> branch! I'm going to build a test ISO right away.
>
> Wrt. commit 4ba3198 ("Run Tor Browser using the TBB's shared
> libraries"), two questions:
>
> * Does this mean that without this commit, the Tor Browser was only
> using system libraries (e.g. NSS)?
For some reason they *were* loaded pre-31esr even without setting
LD_LIBRARY_PATH.
> If it is so, I think the design
> doc needs to make it clear that we *really* need the Tor Browser
> binary to use the bundled libs, and how it's implemented.
Sure, done.
> Also,
> I think we should have at least a manual test about this.
Done in the branch.
> * Doesn't the tor-launcher script need to do the same?
Oops, yes of course. Now fixed.
> (And then,
> the I2P browser one too, and then maybe we should refactor this
> somehow, if it needs to be replicated in 4 different places.)
Good idea, now done.
Cheers!
