On Wed, 1 Oct 2014 01:08:00 +0000 (UTC)
anonym <anonym@???> wrote:
> 29/09/14 04:31, anonym wrote:
> >> I think the changes requested have been addressed. Please see the
> >> latest pushed commits.
> >
> > After these things are fixed, and the user documentation has been
> > upgraded at `wiki/src/doc/anonymous_internet/i2p.mdwn`, I believe
> > it's ready to be merged.
>
> Two more things:
>
> In commit dfbbfe1 (rm adblock & symlink langpacks):
> + for LANGPACK in $(ls
> "${TBB_PROFILE}/extensions/langpack-*.xpi"); do
>
> Here you quote the * so its interpreted literally, not used as a
> wildcard, which breaks the script from running (set -e). This
> completely confuses me, since I was able to test the browser
> before...
Oops. I went a little crazy with 'last minute quoting'. I removed the
quotes.
> I've seen the result of e.g. the later commit 56a01e9
> (Disable searching from the URL bar).
>
> Also, you should merge in feature/tor-browser-bundle -- in particular
> zzz_tails.js has now been renamed 0000tails.js.
Done.
--
GPG ID: 0x5BF72F42D0952C5A
Fingerprint: BD12 65FD 4954 C40A EBCB F5D7 5BF7 2F42 D095 2C5A
