Re: [Tails-dev] [review'n'merge 1.2] feature/7725-i2p-browse…

Nachricht löschen

Nachricht beantworten
Autor: anonym
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] [review'n'merge 1.2] feature/7725-i2p-browser
29/09/14 04:31, anonym wrote:
>> I think the changes requested have been addressed. Please see the
>> latest pushed commits.
>
> After these things are fixed, and the user documentation has been
> upgraded at `wiki/src/doc/anonymous_internet/i2p.mdwn`, I believe it's
> ready to be merged.


Two more things:

In commit dfbbfe1 (rm adblock & symlink langpacks):
+    for LANGPACK in $(ls "${TBB_PROFILE}/extensions/langpack-*.xpi"); do


Here you quote the * so its interpreted literally, not used as a
wildcard, which breaks the script from running (set -e). This completely
confuses me, since I was able to test the browser before... I've seen
the result of e.g. the later commit 56a01e9 (Disable searching from the
URL bar).

Also, you should merge in feature/tor-browser-bundle -- in particular
zzz_tails.js has now been renamed 0000tails.js.

Cheers!