Re: [Tails-dev] [review'n'merge:1.2] feature/7732-i2p-netwo…

Nachricht löschen

Nachricht beantworten
Autor: anonym
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] [review'n'merge:1.2] feature/7732-i2p-network-manager-hook [was: I2P & Tails 1.2 (0.9.15, browser, network-manager))
22/09/14 00:56, Kill Your TV wrote:
> On Wed, 17 Sep 2014 21:02:24 +0000 (UTC)
> Kill Your TV <killyourtv@???> wrote:
>
>> Network-Manager
>> ===============
>>
>> Beginning with Tails 1.1.1, users need to explicitly ask for I2P at
>> the boot prompt. Users still need to start I2P from the menu. Since a
>> user that enters "i2p" as a boot option is clearly interested in
>> running I2P, it was suggested that I2P be started, e.g., via a nm
>> hook. This will also be pushed after I'm able to do a bit more
>> testing. (ticket #7732)
>
>
> This is available at
>
>        git://repo.or.cz/tails/kytv.git    feature/7732-i2p-network-manager-hook

>
> and has been rebased on top of the devel branch.


Thanks!

First, you haven't removed the
`config/chroot_local-includes/usr/local/bin/tails-start-i2p` script,
which imho now is obsolete. Similarly we can remove
`config/chroot_local-includes/usr/share/applications/i2p.desktop*` to
drop the also obsolete Applications -> Internet -> i2p .desktop entry.

A difference compared to the old `tails-start-i2p` is that it opens the
router console in the web browser (starting it if necessary) once it's
ready (simply by waiting for port 7657 to start listening) but your
script doesn't. IMHO it's a pretty good portal to various I2P services
and web pages, so that's a bit of a loss. What do you think?

Regarding commit 2f0b6d2d57bca7e99255fe343810bd30ce572f09:
+ /etc/NetworkManager/dispatcher.d/30-i2p.sh
/usr/local/bin/tails-i2p-notify \

That change is not enough, AFAICT. You must also add appropriate lines
in po/POTFILES.in.

Cheers!