Re: [Tails-dev] [review'n'merge:1.2] feature/5373-replace-tr…

Supprimer ce message

Répondre à ce message
Auteur: Alan
Date:  
À: tails-dev
Sujet: Re: [Tails-dev] [review'n'merge:1.2] feature/5373-replace-truecrypt
Hi,

On Mon, 22 Sep 2014 09:58:59 -0700
intrigeri <intrigeri@???> wrote:
> sajolida@??? wrote (20 Sep 2014 14:36:55 GMT) :
> > See 6c266c5.
>
> I think you forgot to push => reassigning the ticket to you.


I assigned https://labs.riseup.net/code/issues/5932 and
https://labs.riseup.net/code/issues/7739 to me *but* it looks they are
not actually ready to review as they depend
on https://labs.riseup.net/code/issues/6052 (the documentation) which
doens't look ready yet.

I few comments however, as of commit 82722e8:

- code looks good to me ;
- the part about setting up a loopback device in the documentation is
useless, it works well without it as of my tests ;
- I tested feature and the warning and it works well.

Please ping me when the doc is ready so that I can actually merge the
branch.

Cheers