Autor: Kill Your TV Data: Dla: tails-dev Temat: Re: [Tails-dev] [review'n'merge:1.2]
feature/7916-i2p_remove_ssl_outproxy
On Mon, 22 Sep 2014 17:24:29 +0000 (UTC)
intrigeri <intrigeri@???> wrote:
> Hi,
>
> [just a quick look, I'll leave the full review to the current RM]
>
> > +sed -i
> > '/tunnel\.0\.\(proxyList\|option\.i2ptunnel\.httpclient\.SSLOutproxies\)/d'
> > "$I2P/i2ptunnel.config"
>
> Could the regexp be made a bit stricter? (e.g. anchored to the
> beginning of a line, optionally with leading whitespace if needed)
Oops, anchor added. (Of course I did that for the rest of the lines in
that file...).
> Any reason to keep port 4445 open?
No. It's actually closed in ferm in my feature/7725-i2p-browser branch.
> Also, maybe the design doc needs to be updated accordingly.
Perhaps the updates made in feature/7725-i2p-browser are sufficient? If
not I can update it further.
