Autore: intrigeri Data: To: The Tails public development discussion list Oggetto: Re: [Tails-dev] [review'n'merge:1.2]
feature/7916-i2p_remove_ssl_outproxy
Hi,
[just a quick look, I'll leave the full review to the current RM]
> +sed -i '/tunnel\.0\.\(proxyList\|option\.i2ptunnel\.httpclient\.SSLOutproxies\)/d' "$I2P/i2ptunnel.config"
Could the regexp be made a bit stricter? (e.g. anchored to the
beginning of a line, optionally with leading whitespace if needed)
Any reason to keep port 4445 open?
Also, maybe the design doc needs to be updated accordingly.