This is mainly addressed to paskao, but since there was not a proper
place to write these observations, I'm doing it there.
I'll prepend a "priority" tag to these observations; with "blocker" I
mean that I would never merge this if those bugs are not fixed. "medium"
is for bugs that should be solved. "minor" is for bug that maybe in
your, or someone else, opinion, are not bugs.
* [medium] Help->Informazioni does not work. Is that an i18n or a l10n problem,
anyway?
* [minor] https://i.imgur.com/ZrNC772.png the "warning" note should be, IMHO, an
infobar [1]. Now the window is too cluttered
* [minor] The two informative messages should be "joined". If possible, it
could be something like
<strong>What's that?</strong>
The persistence is the....
<strong>Status</strong>
Persistence is not available on your usb drive, but you can create it.
Fill the form...
* [minor] The "create persistence" button should be inside the Options frame.
Which, in turn, should change its name to "create persistence"
* [blocker] Password is shown cleartext instead of "asterisks" inside of the
Options frame.
* [minor] The "refresh" button does not really refresh the window (maybe only
the icon?). If it is too difficult to make it work properly, please
just drop it.
* [minor] When we are in red (absent) status, the window should provide a way of
rebooting just clicking on a button.
* [blocker] It seems not to detect when the persistence is mounted, showing the
red icon instead of the green one. Please note that check-persistence
is-mounted works! The error is in the if chain at line 458. I fixed it
in commit cba1d3f
* [normal] Clicking on the green icon does nothing. A dialog should
appear, confirming that everything is alright, and maybe showing some
statistics; df -h $(check-persistence is-mounted) comes to mind
anyway, this has been a really good work!
[1]
https://developer.gnome.org/gtkmm-tutorial/3.9/sec-infobar.html.en
--
boyska
