Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbf…

Poista viesti

Vastaa
Lähettäjä: Alan
Päiväys:  
Vastaanottaja: tails-dev
Aihe: Re: [Tails-dev] [review'n'merge:1.1.1] bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux [Was: dpkg-dev / libdpkg-perl errors during build]
Hi,

On Thu, 31 Jul 2014 11:46:35 +0200
intrigeri <intrigeri@???> wrote:
> Kill Your TV wrote (30 Jul 2014 21:58:27 GMT) :
> > Your suggested changes seem to have worked. (without apt-cacher-ng &
> > privoxy it passed. If I back out your suggested change, it fails)
>
> Thanks for confirming!
>
> Please review'n'merge
> bugfix/7691-fix-ftbfs-with-apt-get-source-syslinux into stable and
> devel. Candidate for 1.1.1.
>

The code and APT review passes, but:

- I don't know how to reproduce the bug that this is supposed to fix. I
thus trust Kill Your TV's test
- the branch was actually already merged in stable by 554c3c3 "Merge
remote-tracking branch 'kytv/feature/i2p-bootparam' into stable"
because that branch was based on the one I'm supposed to merge. Dear
reviewer of kytv/feature/i2p-bootparam, please check twice what you
merge next time!

Anyway, it's merged and I see no reason to unmerge it.

Cheers