Re: [Tails-dev] [review'n'merge:1.1] feature/vagrant-wheezy-…

Nachricht löschen

Nachricht beantworten
Autor: intrigeri
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] [review'n'merge:1.1] feature/vagrant-wheezy-basebox (#7133, #6736)
Hi,

anonym wrote (21 Jul 2014 16:21:20 GMT) :
> 21/07/14 11:03, intrigeri wrote:
>> ... or maybe one should tell me that the only changes, since last
>> jvoisin's try, were about the basebox building, so we don't care and
>> I should just merge it?


> This is exactly the case, so I think jvoisin can skip the test and you
> merge if you're happy with the code review.


Merged, then, after addressing #7643 in commit f54d20ae2.

*However*, I'm worried about #7644 ("This branch's box.ovf file has
a very small mistake"). We're told it makes the build process fail.
May you please have a look?

I've merged nevertheless, as the new thing seems to work better (at
least, for anonym and jvoisin) that the old one, that was more
obviously broken.

Cheers!
--
intrigeri