Re: [Tails-dev] [PATCH] [review'n'merge] bugfix/#5387 Tails-…

Nachricht löschen

Nachricht beantworten
Autor: Alan
Datum:  
To: tails-dev
Betreff: Re: [Tails-dev] [PATCH] [review'n'merge] bugfix/#5387 Tails-greeter fix quick search in "Other..." window
Hi,

> my first little patch :)


Thanks for your contribution.

> Tested on Tails 1.0.
>

I'm afraid you didn't test exactly that. I had to change search_column
from 0 to 1.

Anyway that's a minor think that I changed, but I had to amend your
commit and thus change its id. Test passes in 1.1~rc1 and it's now
merged in greeter's master.

For next time when you assign a ticket to a reviewer please set "QA
check" to "Ready for QA"

If you are interested on tackling a slightly more complicated task in
the same field you might be interested by:

- #5760: tails-greeter: feedback when repairing damaged persistent
filesystem (Python/Gtk)
- #5502: Notify user if hardware requirements are not met

> Thank you Alan!
>

Thank *you*!

Cheers