Re: [Tails-dev] [review'n'merge:1.1] bugfix/7443-persistent-…

Poista viesti

Vastaa
Lähettäjä: anonym
Päiväys:  
Vastaanottaja: The Tails public development discussion list
Aihe: Re: [Tails-dev] [review'n'merge:1.1] bugfix/7443-persistent-files-permission
01/07/14 19:14, intrigeri wrote:
>>> commit 86da95283669545219492d6f4921eb9cb66dd2eb
>>> Author: Tails developers <amnesia@???>
>>> Date: Mon Jun 30 09:42:07 2014 +0000
>>>
>>>     Remove files as the parent directory's owner.

>>>
>>>     Else, it can't possibly succeed.
>> [...]
>>> -    assert(@vm.execute("rm #{dir}/XXX_persist").success?,
>>> +    owner = @vm.execute("stat -c %U #{dir}").stdout.chomp
>>> +    assert(@vm.execute("rm #{dir}/XXX_persist", user=owner).success?,

>
>> I do not get this. @vm.execute runs the command as root by default, so
>> the owner stuff seems unnecessary.
>
> I had a test failure that was fixed after adding this commit, but it
> might have been for unrelated reasons. Feel free to revert, assuming
> the tests pass without that commit.


I don't feel like I have the time to check this now (I need to start
preparing the RC!), so whatever. :) It shouldn't make anything worse, it
was just that I wondered if there was some special reason that wasn't in
the commit message.

Cheers!