01/07/14 15:22, anonym wrote:
m currently running usb_install.feature with current testing as
> --old-iso, which should test the permission fixes from commit 97961bf in
> an appropriate manner. I'll report back on that.
One minor issue so far:
> commit 97961bf
[...]
> + if [ "$PERSISTENCE_READONLY" = true ]
> + then
> + warning "Permissions of '$subdir' may need to be fixed, but read only was selected; please retry in read-write mode"
> + else
> + chmod go= "$subdir"
> + fi
In usb_install.feature we run "Scenario: Upgrading an old Tails USB
installation from a Tails DVD", and immediately after we run "Scenario:
Booting Tails from a USB drive upgraded from DVD with persistence
enabled". In my case the --old-iso has created the persistent folders
with the unsafe permissions, so now is the time they should be upgraded.
However, in this scenario we enable read-only persistence, so they're no
fixed, and then the step "persistent directories have safe access
rights" fails later on.
BTW, the same applies to the equivalent scenarios when upgrading from
USB, i.e: "Scenario: Upgrading an old Tails USB installation from
another Tails USB drive" and "Scenario: Booting Tails from a USB drive
upgraded from USB with persistence enabled".
There's really no reason to use read-only persistence in these scenarios
(it will block testing of similar fixes in the future) so the fix is simply:
--- a/features/usb_install.feature
+++ b/features/usb_install.feature
@@ -187,7 +186,7 @@ Feature: Installing Tails to a USB drive, upgrading
it, and using persistence
And the network is unplugged
When I start the computer
And the computer boots Tails
- And I enable read-only persistence with password "asdf"
+ And I enable persistence with password "asdf"
And I log in to a new session
Then Tails seems to have booted normally
And Tails is running from USB drive "to_upgrade"
@@ -221,7 +220,7 @@ Feature: Installing Tails to a USB drive, upgrading
it, and using persistence
And the network is unplugged
When I start the computer
And the computer boots Tails
- And I enable read-only persistence with password "asdf"
+ And I enable persistence with password "asdf"
And I log in to a new session
Then Tails seems to have booted normally
And persistence is enabled
@@ -270,7 +269,7 @@ Feature: Installing Tails to a USB drive, upgrading
it, and using persistence
And the network is unplugged
When I start the computer
And the computer boots Tails
- And I enable read-only persistence with password "asdf"
+ And I enable persistence with password "asdf"
And I log in to a new session
Then Tails seems to have booted normally
And persistence is enabled
I optimistically pushed this fix into the bugfix branch in commit
9723367. I hope you don't mind.
Cheers!
