Re: [Tails-dev] Please review and merge again feature/6342-u…

Delete this message

Reply to this message
Autor: intrigeri
Data:  
A: The Tails public development discussion list
Assumpte: Re: [Tails-dev] Please review and merge again feature/6342-update-camouflage-for-gnome3
Hi,

anonym wrote (11 Jun 2014 15:40:13 GMT) :
> 10/06/14 22:01, intrigeri wrote:


>> Regarding #7382 ("Customized icon are way too small in the
>> applications menu"), I'm a bit surprised it's not a blocker.


> It's getting less clear for me what we mean with "blocker". If it means
> that we wouldn't ship this feature in Tails 1.1 unless it's fixed (which
> has been my interpretation so far) then I'm not sure I agree that it
> should be a blocker.


> I'm OK with the *initial* version of this feature (e.g. what we ship in
> Tails 1.1), when activated, introducing regressions as long as they only
> cause small inconvenience, like this one. So, I'd say this is not a
> blocker, even if it'd be great if it could be fixed in time for Tails 1.1.


Fair enough.

>>> - bugfix/7325-task-list-icons
>>
>> The icon assigned to Claws Mail icon is much smaller than one assigned
>> to Pidgin, which is itself a bit smaller than the one assigned to the
>> web browser. Is it the same on Windows?


> I think you're actually observing another bug that I just filed:


>     https://labs.riseup.net/code/issues/7393


Yes, most likely.

> Note that since pidgin initially opens two windows, the main window and
> then the account window, the main windows always gets its icon at full size.


> My initial impression is that this is a blocker, since it deviates from
> how it'd look on Windows 8. But I'm unsure, since the visual impact
> still is pretty small.


> Thoughts on this?


The visual impact is indeed pretty small in our threat model for this
feature. Also, fixing this likely requires patching the
window-picker-applet. So, I'm not sure we should block on this, even
if it would be great to see it fixed between now and the end of the
month (doesn't sound *that* crazy, does it? a bug should be reported
upstream ASAP, anyway, if we want to have a chance to see it fixed in
time, without writing the patch ourselves).

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc