Hi,
On Mon, 2 Jun 2014 20:11:51 +0000
Andres Gomez Ramirez <andres.gomez@???> wrote:
> I attached a patch for https://labs.riseup.net/code/issues/7344,
> "Bug #7344 Double-clicking on an entry in the language or keyboard
> layout lists is not enough".
>
Thanks for the patch.
However, I fail to understand the need of these changes:
- if isinstance(data, Gtk.Dialog):
- data.response(True)
+ self.dialog.response(True)
- why do you drop the check for a dialog?
- why do you use self instead of data (use of data is advised in
callbacks as far as I know)? I think that self.dialog should be
replaced by data.dialog.
The same questions applies for the next change.
Cheers
