anonym:
> 16/05/14 09:52, sajolida@??? wrote:
>>>> Anyway, I'm absolutely not sure I'll be able to fix that before the
>>>> freeze. I'd rather concentrate on the documentation upgrades. So if any
>>>> VirtualBox user want to have a look...
>>>
>>> I haven't done a code review yet, but it looks very promising to me so
>>> expect this to be merged in time for 1.1.
>
> Done now, all looks good. My only non-blocker issues are the following:
>
> 1. To avoid binary bloat in Git, why not generate the fake gcc-4.8
> package (with `equivs-build`) in the hook? I know we cannot access
> `deb-src/gcc-4.8/control` inside live-build's chroot (we will when/if
> we move to 3.x) but we could just put it somewhere in
> `config/chroot_local-includes/` and remove it in the
> `98-remove_unwanted_files` hook.
Ok, that's commit 0a11342 now.
> 2. Why not `apt-get remove` the fake gcc-4.8 after we're done with the
> DKMS stuff? It's not needed after that, and won't break anything,
> unless I've misunderstood something. The presence of that fake
> package could actually confuse users that want to install gcc in
> Tails.
That's commit 9182bbc now.
>>> A potential follow-up is how to document the shortcomings. Known issue,
>>> perhaps?
That's commit 348945e.
I want to rewrite the whole virtualization documentation as part of
#7143, so I just updated the known issues on that one.
--
sajolida
