Hi,
anonym wrote (04 Mar 2014 20:25:25 GMT) :
> 28/02/14 14:08, intrigeri wrote:
>> Also, I would add "|| true" at the end of the sed line, so that this
>> function is safe to use in a "set -e" environment.
> How can the `sed` call fail exactly?
Thinking of it again, I'm taking my comment back.
>>> # Loss of Vidalia's systray icon
>>
>>> Since Vidalia is removed, and Tor Launcher doesn't show a systray icon
>>> indicating Tor's connection state like Vidalia did, there's no
>>> *constant* indication whether Tor is up and running, just the
>>> *temporary* notification we recently introduced. I expect that our users
>>> are heavily trained by now to look for the Vidalia icon.
>>
>>> Any thoughts on this?
>>
>> I think that's another reason not to remove Vidalia until we have
>> a good replacement for it. Perhaps we need a parent ticket called
>> "Remove Vidalia", with subtasks for every such potential blocker.
> Right, this is a non-issue now.
Created #6841 ("Remove Vidalia") to track such potential blockers.
>>> # Loss of old bridge mode explanation
>>
>>> In our old, Vidalia-based bridge mode, a Tails-specific dialog was shown
>>> (thanks to our custom patches), and it mentions the "hide that you're
>>> using Tor" use case. This perspective of bridges is completely absent
>>> from Tor Launcher's corresponding dialog.
>>
>>> Is this an issue?
>>
>>> I suppose that we in the short run can settle with only mentioning this
>>> use case in our user documentation,
>>
>> Agreed. More specifically, this documentation will be available from
>> the greeter, next to the "Use bridges" setting, right?
> Something like that -- it's on sajolida's plate.
>>> In the long run we probably want to convince upstream that this is
>>> a valid use case and have the description changed/complemented.
>>
>> Agreed. I think a ticket about it should be created in the Tor
>> Launcher's Trac.
> I have this on my personal TODO.
So that's now Tor#11132, apparently :)
> Thanks a lot for the review!
Thanks a lot for taking it into account!
Now going to read your other messages, and review the current state of
the code.
Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
