intrigeri wrote (03 Mar 2014 21:46:02 GMT) :
> Code review passes for me. Untested, so I'll let anonym deal with
> the next steps.
I was going to take care of the next steps, to give a hand to anonym,
but:
* HACKING has not been updated to document that one should run the
test suite before releasing (fixed in c31f5a5)
* the test suite does not pass for me (see below); does it pass
for you?
So I'm giving up for now. Alan, do you think you'll have time to take
care of this today? Otherwise, please mark this set of tickets as
postponed to whatever version you think it can be ready for.
======================================================================
FAIL: test_ata_serial (__main__.TestSanitiseHardwareInfo)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test.py", line 66, in test_ata_serial
"ata3.00: ATA-8: Hitachi 123456789ABYZ, JP1234MA, max UDMA/133"
AssertionError: False is not true
----------------------------------------------------------------------
Ran 14 tests in 0.002s
FAILED (failures=1)
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
