Re: [Tails-dev] Please review'n'merge test/5959-antitest-mem…

Nachricht löschen

Nachricht beantworten
Autor: intrigeri
Datum:  
To: The Tails public development discussion list
Betreff: Re: [Tails-dev] Please review'n'merge test/5959-antitest-memory-erasure
Hi,

anonym wrote (28 Feb 2014 14:44:00 GMT) :
> 28/12/13 23:50, intrigeri wrote:
> For whatever reason, the TailsToaster (i.e. `@domain_name`) domain isn't
> present for me (also checked with `virsh list`), [...]


Fixed by commit 0caac4a2, thanks.

> Then I have two probably unrelated problems:


> 1. I consistently get:


>>     And at least 8 GiB of RAM was detected #
>> features/step_definitions/erase_memory.rb:46
>>       Detected 8393662464 bytes of RAM
>>       Didn't detect enough RAM (RuntimeError)
>>       ./features/step_definitions/erase_memory.rb:53:in `/^at least (\d+)
>> ([[:alpha:]]+) of RAM was detected$/'
>>       features/erase_memory.feature:16:in `And at least 8 GiB of RAM was detected'


> We currently allow a 128 MiB "gap", but now the gap is 187 MiB. I
> suppose the switch from a i686-pae to a amd64 kernel is the cause. Can
> you reproduce this?


I can. Applied your fix in 896fdaa.

> 2. I consistently get:


>>   Scenario: Memory erasure on an old computer # features/erase_memory.feature:55
> [...]
>>     Then I find very few patterns in the guest's memory           # features/step_definitions/erase_memory.rb:141
>>       Pattern coverage: 0.164% (6097552 bytes)
>>       0.164% of the memory is filled with the pattern, but less than 0.100% was expected (RuntimeError)
>>       ./features/step_definitions/erase_memory.rb:145:in `/^I find very few patterns in the guest's memory$/'
>>       features/erase_memory.feature:69:in `Then I find very few patterns in the guest's memory'


> The exact pattern coverage of course varies but it's always been
> slightly above 0.1%. We currently only allow 0.001 = 0.1% coverage after
> memory erasure, so we may want to bump it to 0.5%, which still I guess
> is pretty ok (I guess? It feels like we're completely arbitrary here :)).


I've raised it to 0.25% instead (f5558ad), so that we can detect
a bump from 0.15% to 0.49% in the future.

So I think you should now be happy to merge this branch :)

>> Then, only #6483 will remain a blocker to drop this part of our manual
>> test suite, eventually.


> Excellent! Since we now use an amd64 kernel we can close that ticket
> once 0.23 is out.


I've closed it right away, since we're going to use the devel branch
to run the automated test suite when releasing 0.23.

Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc