Re: [Tails-dev] Made New Identity work again, please review

28/02/14 13:56, winterfairy@??? wrote:
>>>>> +TOR_CONTROL_PASSWD='passwd'
>>>>
>>>> Why do we set this?
>>>
>>> Iceweasel (as "amnesia") does not have access to the authentication
>>> cookie, and shouldn't. If Torbutton cannot read the authentication cookie,
>>> it refuses to talk to the control port, even when substituted with this
>>> filter. So I need to tell it what the cookie is using TOR_CONTROL_PASSWD,
>>> and it will now talk to the filter trying to authenticate with this value
>>> instead. The filter accepts all authentication regardless of value, as
>>> noted in the code.
>>
>> Ah, I see. Could you please add a code comment at the place where
>> `TOR_CONTROL_PASSWD` is set, explaining this non-obvious (at least to me
>> :)) assignment?
>
> Done, same branch (winterfairy:bugfix/torbutton-new-identity).

Excellent! It's now merged.

Thanks again for you contribution!

Cheers!