21/02/14 12:13, intrigeri wrote:
> anonym wrote (21 Feb 2014 05:10:08 GMT) :
>>> I'm afraid this won't work very well for drivers that macchanger can't
>>> retrieve the permanent MAC address from, e.g.:
>
>> To be continued after the issue pointed out in the post "Serious issue:
>> fail-safe and hotplugging" (since it seems like the solution to it
>> determines how to deal with this).
>
> This is fixed by the new fail-safe mechanism, right?
I guess you may have seen elsewhere by now (e.g. in the ticket) that,
yes, that was fixed (in commit b32d80d) in the midst of the work for the
new fail-safe mechanism.
>>>> + # We can't use Desktop::Notify since this script is supposed to be run
>>>> + # as root (for access to syslog), started in an env without DESKTOP etc,
>>>> + # which also causes issues with opening links in the text body.
>>>
>>> ... then we should *not* use links that don't work in the text body.
>
>> Either you misunderstood that comment, or I misunderstand you. By using
>> the `tails-notify-user` wrapper, like the script currently does, links
>> work just fine. The comment is about Desktop::Notify not being an
>> alternative to `tails-notify-user` if we want links to work, which I
>> think is a good thing to do when we can, like in this case.
>
>> Do you agree? If so, feel free to clarify the code comment if you feel
>> it is unclear.
>
> We agree. Clarified comment in 84e09ae.
Thanks!
Cheers!
