Re: [Tails-dev] [RFC] Design (and prototype) for MAC spoofin…

Delete this message

Reply to this message
Autore: intrigeri
Data:  
To: The Tails public development discussion list
Oggetto: Re: [Tails-dev] [RFC] Design (and prototype) for MAC spoofing in Tails
Hi,

I've had a look at the latest tails-greeter changes.

Looks good, but a minor comment:

> UNBLOCK_NETWORK_LOG="$(/usr/local/sbin/tails-unblock-network 2>&1)"
> UNBLOCK_NETWORK_RET=$?
> if [ "${UNBLOCK_NETWORK_RET}" -ne 0 ]; then
>    log_error "tails-unblock-network exited with non-zero status and said:
> ${UNBLOCK_NETWORK_LOG}"


Why not log the exit code too?

Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc