Hi,
anonym wrote (21 Feb 2014 05:10:08 GMT) :
> See commit 6881869 for migration from ifconfig to ip. However, ip isn't
> particularly well-suited for grep:ing the output of (not that ifconfig
> is any better) so I opted to use the sysfs interface instead when
> possible for less regex spaghetti and greater clarity. For that, see
> commit 940690c.
I like it.
>> I'm afraid this won't work very well for drivers that macchanger can't
>> retrieve the permanent MAC address from, e.g.:
> To be continued after the issue pointed out in the post "Serious issue:
> fail-safe and hotplugging" (since it seems like the solution to it
> determines how to deal with this).
This is fixed by the new fail-safe mechanism, right?
>>> + # We can't use Desktop::Notify since this script is supposed to be run
>>> + # as root (for access to syslog), started in an env without DESKTOP etc,
>>> + # which also causes issues with opening links in the text body.
>>
>> ... then we should *not* use links that don't work in the text body.
> Either you misunderstood that comment, or I misunderstand you. By using
> the `tails-notify-user` wrapper, like the script currently does, links
> work just fine. The comment is about Desktop::Notify not being an
> alternative to `tails-notify-user` if we want links to work, which I
> think is a good thing to do when we can, like in this case.
> Do you agree? If so, feel free to clarify the code comment if you feel
> it is unclear.
We agree. Clarified comment in 84e09ae.
Cheers!
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
